Use theforeman github actions for ruby testing #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosas
force-pushed
the
foreman-action
branch
from
10e495c
to
939c3eb
Compare
|
I know it is only partly related, but if we are running tests only on node 14 here, should we keep the js_tests for node 12? Also I think that we should move forward and add tests for Ruby 3.0 but we can do that in a follow-up PR as this will for sure result in some follow-up tasks that target code fixing. |
dosas
force-pushed
the
foreman-action
branch
from
939c3eb
to
3131fee
Compare
|
@nadjaheitmann looks like node 12 is not supported by the shared actions |
|
Let's drop it then |
dosas
force-pushed
the
foreman-action
branch
from
3131fee
to
ebfc109
Compare
nadjaheitmann
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.